Another Monday Links. Five articles I found interesting in last month.
Don’t waste time on heroic death marches
“Successful companies, whether they’re programming houses, retailers, law firms, whatever, make their employees’ needs a priority.” Totally agree. No more comments! Read full article
How to study effectively
One of my favorite subjects: how to study. Don’t cram. Don’t reread the material. Don’t highlight. Instead, study in short sessions and recall the material. Easy! There are even more strategies. Read full article
Undervalued Software Engineering Skills: Writing Well
We, as developers, spend a lot of time writing prose, not only code. Commit messages, ticket and PR descriptions, README files. We should get better at it. To check my writings, I use the Hemingway app often. Read full article
15 signs you joined the wrong company as a developer
Number 12. and 13. are BIG red flags. Let’s pay attention to those. Recently, I read about “disagree with your feet.” It resonates with this article. When you don’t like something about your job and you can’t do anything about it, walk away. Read full article
No, we won’t have a video call for that
I don’t like those chat messages with only “Hi!” or “How are you?” when we both know that’s not the message. This article shows how to better communicate on remote teams. Embrace asynchronous communication. Prefer (in order) Issue tracker, Wiki, email, and chat. Stay away from video calls as much as possible. Don’t ping people on chat software. And other ideas. Read full article, Watch full presentation.
Voilà! This Monday Links ended up being about better workplaces. See you in a month or two in the next Monday Links! In the meantime, grab your own copy of my free eBook Unit Testing 101. Don’t miss the previous Monday Links on Farmers, Incidents and Holmes.
Today, I needed to pass a dictionary between two ASP.NET Core 6.0 API sites. To my surprise, on the receiving side, I got the dictionary with all its keys converted to lowercase instead of PascalCase. I couldn’t find any element on the dictionary, even though the keys had the same names on each API site. This is what I learned about serializing dictionary keys.
Serialization with Newtonsoft.Json
It turns out that the two API sites were using Newtonsoft.Json for serialization. Both of them used the CamelCasePropertyNamesContractResolver when adding Newtonsoft.Json.
Something like this,
usingNewtonsoft.Json.Serialization;usingNewtonsoft.Json;varbuilder=WebApplication.CreateBuilder(args);builder.Services.AddControllers().AddNewtonsoftJson(options=>// ^^^^^{options.SerializerSettings.NullValueHandling=NullValueHandling.Ignore;options.SerializerSettings.ContractResolver=newCamelCasePropertyNamesContractResolver();// ^^^^^// This is what I mean});varapp=builder.Build();app.MapControllers();app.Run();
With CamelCasePropertyNamesContractResolver, Newtonsoft.Json writes property names in camelCase. But, Newtonsoft.Json treats dictionary keys like properties too.
That was the reason why I got my dictionary keys in lowercase. I used one-word names and Newtonsoft.Json made them camelCase.
To prove this, let’s create a simple controller that read and writes a dictionary. Let’s do this,
usingMicrosoft.AspNetCore.Mvc;namespaceLowerCaseDictionaryKeys.Controllers;[ApiController][Route("[controller]")]publicclassDictionaryController:ControllerBase{[HttpPost]publicMyViewModelPost(MyViewModelinput){returninput;// ^^^^^// Just return the same input}}publicclassMyViewModel{publicIDictionary<string,string>Dict{get;set;}}
Now, let’s notice in the output from Postman how the request and the response differ. The keys have a different case. Arggg!
Postman request and response bodies
1. Configure Newtonsoft.Json naming strategy
To preserve the case of dictionary keys with Newtonsoft.Json, configure the ContractResolver setting with CamelCaseNamingStrategy class and set its ProcessDictionaryKeys property to false.
When registering Newtonsoft.Json, in the SerializerSettings option, let’s do:
usingNewtonsoft.Json.Serialization;usingNewtonsoft.Json;varbuilder=WebApplication.CreateBuilder(args);builder.Services.AddControllers().AddNewtonsoftJson(options=>// ^^^^^{options.SerializerSettings.NullValueHandling=NullValueHandling.Ignore;options.SerializerSettings.ContractResolver=newCamelCasePropertyNamesContractResolver{NamingStrategy=newCamelCaseNamingStrategy{ProcessDictionaryKeys=false// ^^^^^// Do not change dictionary keys casing}};});varapp=builder.Build();app.MapControllers();app.Run();
After changing the naming strategy, let’s see the response of our sample controller. That’s what I wanted!
Postman request and response bodies
What about System.Text.Json?
To maintain case of dictionary keys with System.Text.Json, let’s set the DictionaryKeyPolicy property inside the JsonSerializerOptions to JsonNamingPolicy.CamelCase.
Another alternative is to use a dictionary with a comparer that ignores case of keys.
On the receiving API site, let’s add an empty constructor on the request view model to initialize the dictionary with a comparer to ignore cases.
In my case, I was passing a metadata dictionary between the two sites. I could use a StringComparer.OrdinalIgnoreCase to create a dictionary ignoring the case of keys.
This way, no matter the case of keys, I could find them when using the TryGetValue() method.
Voilà! That’s how we can configure the case of dictionary keys when serializing requests and how to read dictionaries with keys no matter the case of its keys.
We have covered some common mistakes when writing unit tests. Some of them may seem obvious. But, we all have made this mistake when we started to write unit tests. This is the most common mistake when writing unit tests and how to fix it.
Don’t repeat the logic under test when verifying the expected result of tests. Instead, use known, hard-coded, pre-calculated values.
Let’s write some tests for Stringie, a (fictional) library to manipulate strings with a fluent interface. Stringie has a Remove() method to remove substrings from the end of a string.
When writing unit tests, don’t copy the tested logic and paste it into private methods to use them inside assertions.
If we bring the tested logic to private methods in our tests, we will have code and bugs in two places. Duplication is the root of all evil. Even, inside our tests.
Please, don’t write assertions like the one in this test.
[TestMethod]publicvoidRemove_ASubstring_RemovesThatSubstringFromTheEnd(){stringstr="Hello, world!";stringtransformed=str.Remove("world!").From(The.End);Assert.AreEqual(RemoveFromEnd(str,"world!"),transformed);// ^^^^^// We duplicate the Remove logic in another method}privatestringRemoveFromEnd(stringstr,stringsubstring){varindex=str.IndexOf(substring);returnindex>=0?str.Remove(index,substring.Length):str;}
Also, by mistake, we expose the internals of the tested logic to use them in assertions. We make private methods public and static. Even to test those private methods directly.
From our Unit Testing 101, we learned to write unit tests through public methods. We should test the observable behavior of our tested code. A returned value, a thrown exception, or an external invocation.
Again, don’t write assertions like the one in this test.
[TestMethod]publicvoidRemove_ASubstring_RemovesThatSubstringFromTheEnd(){stringstr="Hello, world!";stringtransformed=str.Remove("world!").From(The.End);Assert.AreEqual(Stringie.PrivateMethodMadePublicAndStatic(str),transformed);// ^^^^^// An "internal" method exposed to our tests }
Use known values to Assert
Instead of duplicating the tested logic, by exposing internals or copy-pasting code into assertions, use a known expected value.
For our sample test, let’s simply use the expected substring "Hello,". Like this,
[TestMethod]publicvoidRemove_ASubstring_RemovesThatSubstringFromTheEnd(){stringstr="Hello, world!";stringtransformed=str.Remove("world!").From(The.End);Assert.AreEqual("Hello,",transformed);// ^^^^^^^^// Let's use a known value in our assertions}
If we end up using the same expected values, we can create constants for them. Like,
Voilà! That’s the most common mistake when writing unit tests. It seems silly! But often, we duplicate Math operations and string concatenations and it passes unnoticed. Remember, don’t put too much logic in your tests. Tests should be only assignments and method calls.
Want to write readable and maintainable unit tests in C#? Join my course Mastering C# Unit Testing with Real-world Examples on Udemy and learn unit testing best practices while refactoring real unit tests from my past projects. No more tests for a Calculator class.
In this part of the C# idioms series, we have one idiom to write more intention-revealing defaults and another idiom to convert mapping code using a switch to a more compact alternative using a dictionary.
Use intention-revealing defaults
When initializing variables to default values, use intention-revealing alternatives.
Are you initializing a string variable to later assign it? Use "". Do you want to return an empty string from a method? Use string.Empty.
The same is true for collections. If you’re initializing a collection to later add some elements, use the normal constructors like new string[length]; or new List<string>();.
But, if you want to return an empty collection. Use Array.Empty<string>() or Enumerable.Empty<string>().
Replace switch with a dictionary
Replace switch mapping two types with a dictionary.
Turn every value in the case statements into a key in the dictionary. And, turn the returned value in every case into the value of the matching key in the dictionary.
To replace the default case, take advantage of the TryGetValue() or GetValueOrDefault() methods.
Before, to map from a credit card brand name in strings to a CardType enum, we did this,
C# is a language in constant evolution. It has changed a lot since its initial versions in the early 2000’s. Every version brings new features to write more concise and readable code. These are some C# features I like the most and use often. Hope you find them useful too.
Let’s start with the best C# features by version, starting from version 6.
C# 6.0
String interpolation: $”Hello, {name}”
Before with string.Format(), we could miss a parameter or add them in the wrong order. If we forgot a parameter, we will get a FormatException.
With string interpolation, we can inline variables directly in the string we want to build. To use string interpolation, before the opening quote of your string, let’s add $ and wrap our variables around {}.
Before with string.Format(),
string.Format("Hello, {0} {1}",title,name);
But, if we forgot to add one parameter,
string.Format("Hello, {0} {1}",title/*, I forgot to add the name parameter*/);// ^^^^^// System.FormatException:// Index (zero based) must be greater than or equal to zero and less than the size of the argument list.
After with string interpolation,
$"Hello, {title}{name}";
Now, it’s clearer if we’re missing a parameter or if we have them in the wrong order.
Null-conditional (?.) and null-coalescing operators (??)
Starting from C# 6.0, we have two new operators: null-conditional ?. and null-coalescing ?? operators. These two new operators helps us to get rid of null values and NullReferenceException.
With the null-conditional ?. operator, we access a member’s object if the object isn’t null. Otherwise, it returns null.
The null-coalescing ?? operator evaluates an alternative expression if the first one is null.
Notice, how the ?? operator evaluates the expression on the right, which is a throw.
newMovie("Titanic",null);// ^^^^^// System.ArgumentNullException: Value cannot be null.// Parameter name: director
out variables
We can inline the variable declaration next to the out keyword using the var keyword.
Before, we had to declare a variable in a separate statement,
intcount=0;int.TryParse(readFromKey,outcount);
After, inlining the variable declaration,
int.TryParse(readFromKey,outvarcount);// ^^^
Instead of declaring a variable, we can use discards _ to ignore the output value. For example,
int.TryParse(readFromKey,out_);
I’m not a big fan of methods with out references. But, with this feature I like them a bit more. I prefer tuples.
Tuples
Speaking of tuples…Now we can access tuple members by name. We don’t need to use Item1 or Item2 anymore.
We can declare tuples wrapping its members inside parenthesis. For example, to declare a pair of coordinates, it would be (int X, int Y) origin = (0, 0).
We can use named members when declaring methods and deconstructing returned values.
On another hand, we can use a when clause inside switch.
Before, we had to rely on if statements inside the same case, like this
varemployee=CreateEmployee();switch(employee){caseSalaryEmployeesalaryEmployee:if(salaryEmployee.Salary>1000){DoSomething(salaryEmployee);}else{DoSomethingElse(salaryEmployee);}break;// other cases... }
Now, with pattern matching, we can have separate cases,
varemployee=CreateEmployee();switch(employee){caseSalaryEmployeesalaryEmployeewhensalaryEmployee.Salary>1000:// ^^^^DoSomething(salaryEmployee);break;caseSalaryEmployeesalaryEmployee:DoSomethingElse(salaryEmployee);break;// other cases...}
I found it more readable this way. Let’s keep the conditional case before the one without conditions.
Speaking of switch statements, starting from C# 8.0 switch are expressions. It means we can assign a switch to a variable or return a switch from a method.
Switch expressions are more compact, right? Did you notice we assigned the result of the switch to the cardType variable? Cool!
Indices and ranges
If you have used negative indices in Python, you would find this feature familiar. In Python, we use negative indices to reference elements from the end of lists.
We have a similar feature in C#, not with negative indices, but with the index from end operator, ^.
With the index from end operator, the last element of an array would be array[^1].
Before, we had to substract from the length of the array to access an element from the end. The last element of an array was array[array.Length - 1].
Do you remember the ?. and ?? operators? Now, there is another operator to work with null. The null-coalescing assignment operator, ??=. It only assigns a variable if its value isn’t null.
A variable preceded by using is disposed at the end of the scope. We can get rid of the parethensis around using statements and the brackets wrapping its body.
Before,
using(varreader=newStreamReader(fileName)){stringline;while((line=reader.ReadLine())!=null){// Do something }}
After,
usingvarreader=newStreamReader(fileName);stringline;while((line=reader.ReadLine())!=null){// Do something }
Nullable reference types
With C# 8.0, all reference variables are non-nullable by default. Any attempt to dereference a nullable reference gets a warning from the compiler. Goodbye, NullReferenceException!
To declare a variable that can be null, we need to add to its type declaration an ?. The same way we have always declared nullable value types like int?. For example, a nullable string would be string? canBeNull;
This is a breaking change. We need to turn on this feature at the project level. To do so, let’s add <Nullable>enable</Nullable> inside the PropertyGroup in our csproj files.
For a console application, the csproj file with this feature turned on look like this:
Before, if we access a member of a null reference, we get a NullReferenceException.
stringname=null;SayHi(name);// <- System.NullReferenceException// ^^^// System.NullReferenceException: 'Object reference not set to an instance of an object.'// name was null.voidSayHi(stringname)=>Console.WriteLine(name.Trim());
But now, we get a compiler warning,
stringname=null;// ^^^^^// warning CS8600: Converting null literal or possible null value to non-nullable type.string?canBeNullName=null;SayHi(name);// ^^^^^// warning CS8604: Possible null reference argument for parameter 'name'
To get rid of the compiler warning, we have to check for null values first.
A record is an immutable reference type with built-in equality methods. When we create a record, the compiler creates ToString(), GetHashCode(), value-based equality methods, a copy constructor and a deconstructor.
Records are helpful to replace value-objects in our code.
publicrecordMovie(stringTitle,intReleaseYear);
Top-level statements
All the boilerplate code is now gone from Main methods. It gets closer to scripting languages like Python and Ruby.
Before, to write the “Hello, world!” program in C#, we needed to bring namespaces, classes, methods and arrays only to print a message out to the console.
Now, with Top-level statements and global using statements, it’s a single line of code,
Console.WriteLine("Hello World!");
This is a feature is enabled by default, but we can turn it off in our csproj files. For example, this is the csproj file of a Console app with global using statements and nullable references.
Voilà! These are the C# features I like the most. Which ones didn’t you know about? Which ones you use most often? What features would you like to see in future versions?